Fuckup on 2026-02-27-13-37-29
Prompt:
I'm working on a patch that will remove an old experiment from chromium and add a new experiment in its place. The old experiment was called "MediaPickerAdoption" and the new one should be called "MediaPickerRegression". I've only gotten partway through the CL, but I don't quite understand how to get chromium features plumbed through to android. The old experiment had multiple groups, but mine only should have an enabled/disabled group, and I think that changes how things should be done. You can find most of the changes here: /chromium/src/components/browser_ui/photo_picker/android/java/src/org/chromium/components/browser_ui/photo_picker/PhotoPickerFeatures.java. You should use 'git diff main' to show what the changes are that I've made so far.
Patch:
@@ -10,11 +10,29 @@ #include "components/browser_ui/photo_picker/android/photo_picker_jni_headers/PhotoPickerFeatures_jni.h" namespace photo_picker {+ namespace features { ++ BASE_FEATURE(kAndroidMediaPickerRegression,++ +"MediaPickerRegression",++ +base::FEATURE_DISABLED_BY_DEFAULT);+++ + + static int64_t+ JNI_PhotoPickerFeatures_GetAndroidMediaPickerRegressionFeature(+ JNIEnv* env) {+ +return reinterpret_cast<int64_t>(&kAndroidMediaPickerRegression);++ ++}+++ } // namespace features+ } // namespace photo_picker DEFINE_JNI(PhotoPickerFeatures)